feat(go2): v2.3.0 persist --disable-confirm and add --confirm-distance threshold#2323
feat(go2): v2.3.0 persist --disable-confirm and add --confirm-distance threshold#2323mrhoribu wants to merge 2 commits into
Conversation
…e threshold - Add --disable-confirm=on/off persistent flag; bare --disable-confirm retains existing one-shot behavior - Add --confirm-distance=<N> to configure the distance threshold (replaces hardcoded 20); minimum value 20, default 20 - Seed CharSettings['disable_confirm']=false and CharSettings['confirm_distance']=20 on first run for back-compat - Show both settings in `;go2 list` output and help text
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe ChangesTrip Confirmation Settings
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/go2.lic (1)
1044-1045:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix Rubocop indentation failure in chained call.
Line 1045 must align
.eachwith.find_allto satisfyLayout/MultilineMethodCallIndentation(currently failing CI).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/go2.lic` around lines 1044 - 1045, The chained call indentation for Map.list.find_all { |iroom| ... }.each is incorrect; move the `.each` to a new line aligned under `.find_all` so the block passed to `.each` is indented one level deeper than the call (i.e., align `.each` with `.find_all` and indent the `{ |iroom| output << ... }` or do-block accordingly) to satisfy Layout/MultilineMethodCallIndentation for the Map.list.find_all / .each chain that builds the output string.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/go2.lic`:
- Around line 1189-1190: The parsed --confirm-distance
(setting_confirm_distance) is never applied for one-shot trips with a target
because distance checks still read CharSettings['confirm_distance']; update the
trip-start/confirmation logic (where distance is compared against CharSettings,
e.g., in the one-shot target handling and any confirmation checks) to prefer
setting_confirm_distance when it is non-nil, falling back to
CharSettings['confirm_distance'] otherwise; ensure the same change is applied at
the other occurrences that initialize or check setting_confirm_distance so the
flag actually overrides the CharSettings value for one-shot trips.
---
Outside diff comments:
In `@scripts/go2.lic`:
- Around line 1044-1045: The chained call indentation for Map.list.find_all {
|iroom| ... }.each is incorrect; move the `.each` to a new line aligned under
`.find_all` so the block passed to `.each` is indented one level deeper than the
call (i.e., align `.each` with `.find_all` and indent the `{ |iroom| output <<
... }` or do-block accordingly) to satisfy Layout/MultilineMethodCallIndentation
for the Map.list.find_all / .each chain that builds the output string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
1 participant
;go2 listoutput and help textSummary by CodeRabbit
go2script to v2.3.0 with persistent trip confirmation configuration--disable-confirmflag to customize trip confirmation behavior--confirm-distanceflag to set a custom confirmation distance threshold (minimum 20)