fix(ledger.lic): v1.4.3 change estimate_loot_cap to be Sun thru Sat

[mrhoribu]

Summary by CodeRabbit

• Bug Fixes
  • Updated the loot cap weekly estimation window to begin on Sunday and end on Saturday (EST/EDT), replacing the previous Monday–Sunday calculation. This correction improves the accuracy of weekly loot capacity tracking and ensures proper time zone conversion for local time-based filtering, providing more reliable weekly estimates.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 84ef1124-aa65-4a17-80f8-7134ed9e004e

📥 Commits

Reviewing files that changed from the base of the PR and between bb46d5b and 9b0bebe.

📒 Files selected for processing (1)

• scripts/ledger.lic

---

📝 Walkthrough

Walkthrough

Single-file update to scripts/ledger.lic: version bumped to 1.4.3, changelog and function documentation updated, and the estimate_loot_cap week-start boundary adjusted from Monday 00:00 to Sunday 00:00 (EST/EDT) with corresponding day-offset and timestamp logic changes.

Changes

Loot-cap weekly window boundary adjustment

Layer / File(s)	Summary
Version and documentation updates scripts/ledger.lic	Version bumped 1.4.2 → 1.4.3 with changelog entry documenting the estimate_loot_cap weekly window change from Monday–Sunday to Sunday–Saturday (EST/EDT). Function heading comment updated to describe the new window.
Weekly window calculation adjustment scripts/ledger.lic	Core calculation logic in estimate_loot_cap modified: day-offset and midnight timestamp conversion updated to anchor the weekly interval at Sunday 00:00 (EST/EDT) instead of Monday 00:00.

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• elanthia-online/scripts#2318: Both PRs modify Ledger::Character.estimate_loot_cap at the same function level, with v1.4.2 adding account-based weekly loot-cap estimation and v1.4.3 adjusting the weekly window boundary.
• elanthia-online/scripts#2313: Both PRs update estimate_loot_cap week-boundary logic, with the prior PR introducing DST-aware weekly windows and this PR shifting the week-start day from Monday to Sunday.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: updating the estimate_loot_cap function's weekly window from Mon-Sun to Sun-Sat, which is the primary focus of the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ledger-v1.4.3

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}