fix(map.lic): v2.1.4 various GTK/ruby crashes#2340
Open
mrhoribu wants to merge 3 commits into
Open
Conversation
Updated version to 2.1.3 and added changelog entries for bug fixes and improvements.
This comment has been minimized.
This comment has been minimized.
Updated version to 2.1.4 and added changelog for new features and fixes related to transient dialog handlers.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/map.lic`:
- Around line 548-550: The comment above the instance variable `@_dialog_gc`
contains a non-ASCII em-dash which trips RuboCop's Style/AsciiComments; edit the
comment that precedes `@_dialog_gc` to replace the em-dash "—" with an ASCII
equivalent (e.g., "--" or "-") so the comment reads using only ASCII characters
while leaving the `@_dialog_gc` array and surrounding logic unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Contributor
Author
|
@coderabbitai remove all previous comments and review in full |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# List all review comments by coderabbitai on PR `#2340`
gh pr view 2340 --repo elanthia-online/scripts --json reviews,comments
# Also get review thread IDs to resolve them
gh api graphql -f query='
{
repository(owner: "elanthia-online", name: "scripts") {
pullRequest(number: 2340) {
reviewThreads(first: 100) {
nodes {
id
isResolved
comments(first: 1) {
nodes {
author {
login
}
body
}
}
}
}
}
}
}'Length of output: 24324 🏁 Script executed: #!/bin/bash
# Minimize the top-level coderabbitai comment (rate-limit/walkthrough)
gh api graphql -f query='
mutation {
minimizeComment(input: {subjectId: "IC_kwDOBk72Ws8AAAABELzoDw", classifier: OUTDATED}) {
minimizedComment {
isMinimized
minimizedReason
}
}
}'Length of output: 430
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version to 2.1.4 and added changelog entries for bug fixes and improvements.
Summary by CodeRabbit
Bug Fixes
Documentation