Skip to content

fix(map.lic): v2.1.4 various GTK/ruby crashes#2340

Open
mrhoribu wants to merge 3 commits into
masterfrom
fix/map-v2.1.3
Open

fix(map.lic): v2.1.4 various GTK/ruby crashes#2340
mrhoribu wants to merge 3 commits into
masterfrom
fix/map-v2.1.3

Conversation

@mrhoribu
Copy link
Copy Markdown
Contributor

@mrhoribu mrhoribu commented May 29, 2026

Updated version to 2.1.4 and added changelog entries for bug fixes and improvements.

Summary by CodeRabbit

  • Bug Fixes

    • Prevented crashes caused by signal handlers returning non-Boolean values.
    • Stabilized menu, dialog, and dynamic menu behavior to avoid premature cleanup.
    • Hardened shutdown to prevent crashes during application teardown.
    • Improved memory management to avoid premature finalization of UI elements.
  • Documentation

    • Added notes on signal-handler invariants for more robust event handling.

Review Change Stack

Updated version to 2.1.3 and added changelog entries for bug fixes and improvements.
@coderabbitai

This comment has been minimized.

Updated version to 2.1.4 and added changelog for new features and fixes related to transient dialog handlers.
@mrhoribu mrhoribu changed the title fix(map.lic): v2.1.3 various GTK/ruby crashes fix(map.lic): v2.1.4 various GTK/ruby crashes May 30, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/map.lic`:
- Around line 548-550: The comment above the instance variable `@_dialog_gc`
contains a non-ASCII em-dash which trips RuboCop's Style/AsciiComments; edit the
comment that precedes `@_dialog_gc` to replace the em-dash "—" with an ASCII
equivalent (e.g., "--" or "-") so the comment reads using only ASCII characters
while leaving the `@_dialog_gc` array and surrounding logic unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b818ef88-231b-4555-9a26-fee67ac07faa

📥 Commits

Reviewing files that changed from the base of the PR and between a498adc and b400c31.

📒 Files selected for processing (1)
  • scripts/map.lic

Comment thread scripts/map.lic Outdated
@mrhoribu
Copy link
Copy Markdown
Contributor Author

@coderabbitai remove all previous comments and review in full

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# List all review comments by coderabbitai on PR `#2340`
gh pr view 2340 --repo elanthia-online/scripts --json reviews,comments

# Also get review thread IDs to resolve them
gh api graphql -f query='
{
  repository(owner: "elanthia-online", name: "scripts") {
    pullRequest(number: 2340) {
      reviewThreads(first: 100) {
        nodes {
          id
          isResolved
          comments(first: 1) {
            nodes {
              author {
                login
              }
              body
            }
          }
        }
      }
    }
  }
}'

Length of output: 24324


🏁 Script executed:

#!/bin/bash
# Minimize the top-level coderabbitai comment (rate-limit/walkthrough)
gh api graphql -f query='
mutation {
  minimizeComment(input: {subjectId: "IC_kwDOBk72Ws8AAAABELzoDw", classifier: OUTDATED}) {
    minimizedComment {
      isMinimized
      minimizedReason
    }
  }
}'

Length of output: 430



@mrhoribu Done! My previous comment has been minimized and a full review is now underway. Results will be posted shortly. 🐇✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant