Conversation
Contributor
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
|
⛔️ Test failed Results
|
imays11
approved these changes
Apr 10, 2026
| "Data Source: Microsoft 365", | ||
| "Data Source: Microsoft 365 Audit Logs", | ||
| "Data Source: Microsoft Defender for Endpoint", | ||
| "Data Source: Microsoft Defender XDR", |
Contributor
There was a problem hiding this comment.
If we do this, I'd just remove all of the other Microsoft Defender references.
| "logs-sentinel_one_cloud_funnel.*": {"all": ["Data Source: SentinelOne"]}, | ||
| "logs-fim.event-*": {"all": ["Data Source: File Integrity Monitoring"]}, | ||
| "logs-m365_defender.event-*": {"all": ["Data Source: Microsoft Defender for Endpoint"]}, | ||
| "logs-m365_defender.event-*": {"all": ["Data Source: Microsoft Defender XDR"]}, |
Contributor
There was a problem hiding this comment.
Any min-stacked rules this may break?
terrancedejesus
approved these changes
Apr 10, 2026
Contributor
terrancedejesus
left a comment
There was a problem hiding this comment.
Double check any min-stacked rules where the unit test enforcement may fail on older branches. If any other Microsoft Defender data source tags, I'd remove. Other than these, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #5346
Summary
Updates "Microsoft Defender for Endpoint" mentions/tags to "Microsoft Defender XDR" for clarity.