Fix TOML transform sections for Tomlet / docs-builder#5931
Open
Mpdreamz wants to merge 3 commits intoelastic:mainfrom
Open
Fix TOML transform sections for Tomlet / docs-builder#5931Mpdreamz wants to merge 3 commits intoelastic:mainfrom
Mpdreamz wants to merge 3 commits intoelastic:mainfrom
Conversation
Tomlet requires an explicit [transform] table before [[transform.investigate]] array tables. Rules that placed [[transform.investigate]] after [rule] without [transform] broke the documentation build (MissingIntermediateInTomlTableArraySpecException). Move [transform] and all [[transform.investigate]] blocks to immediately after [metadata], consistent with other rules (e.g. command_and_control_common_webservices). Update updated_date on touched rules. Made-with: Cursor
w0rk3r
reviewed
Apr 8, 2026
| @@ -127,54 +179,6 @@ field_names = [ | |||
| "powershell.file.script_block_length" | |||
| ] | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Can we add it here instead? That way we don't need to scroll down that much to see the rule main logic
Suggested change
| [transform] |
Member
Author
There was a problem hiding this comment.
@w0rk3r updated to ensure rule is before transform!
w0rk3r
requested changes
Apr 8, 2026
Place [transform] and [[transform.investigate]] immediately after [metadata] and before [rule], with an explicit [transform] header before investigate blocks. Matches patterns like command_and_control_common_webservices.toml and satisfies Tomlet (avoids MissingIntermediateInTomlTableArraySpecException). Update updated_date on touched rules. Made-with: Cursor
Contributor
|
Just checking @Mpdreamz , does it make sense to have this change the format of the TOML files? Given that the TOML does not provide/enforce key ordering, might that still make it prone to produce the error even with this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tomlet requires an explicit [transform] table before [[transform.investigate]] array tables. Rules that placed [[transform.investigate]] after [rule] without [transform] broke the documentation build (MissingIntermediateInTomlTableArraySpecException).
Move [transform] and all [[transform.investigate]] blocks to immediately after [metadata], consistent with other rules (e.g. command_and_control_common_webservices).
Update updated_date on touched rules.
Made-with: Cursor
Pull Request
Issue link(s):
Summary - What I changed
How To Test
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist