Skip to content

docs-deploy: Collapse three glob matchers into one #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reakaleek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs-deploy: Collapse three glob matchers into one #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 13 additions & 26 deletions .github/workflows/docs-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,27 +113,22 @@ jobs:
const ignoreLines = (process.env.IGNORE_PATTERNS || '')
.split('\n').map(s => s.trim()).filter(Boolean);

const matchesPattern = (filename) => {
if (pathPattern === '**' || pathPattern === '') return true;
if (pathPattern.endsWith('/**')) {
return filename.startsWith(pathPattern.slice(0, -3) + '/');
// No checkout in this workflow_run phase, so patterns are matched
// against API filenames: dir/** (subtree), dir/* (direct children), exact.
const matchesGlob = (f, pattern) => {
if (pattern.endsWith('/**')) return f.startsWith(pattern.slice(0, -3) + '/');
if (pattern.endsWith('/*')) {
const dir = pattern.slice(0, -2);
return f.startsWith(dir + '/') && !f.slice(dir.length + 1).includes('/');
}
return true;
return f === pattern;
};

const isIgnored = (filename) => {
for (const pattern of ignoreLines) {
if (pattern.endsWith('/**')) {
if (filename.startsWith(pattern.slice(0, -3) + '/')) return true;
} else if (pattern.endsWith('/*')) {
const dir = pattern.slice(0, -2);
if (filename.startsWith(dir + '/') && !filename.slice(dir.length + 1).includes('/')) return true;
} else if (filename === pattern) {
return true;
}
}
return false;
};
// Fails open: any pattern shape other than dir/** matches everything.
const matchesPattern = (filename) =>
!pathPattern.endsWith('/**') || matchesGlob(filename, pathPattern);

const isIgnored = (filename) => ignoreLines.some(p => matchesGlob(filename, p));

if (event === 'push') {
core.setOutput('base-ref', headBranch);
Expand Down Expand Up @@ -233,14 +228,6 @@ jobs:
const valeIncludes = valePathLines.filter(p => !p.startsWith('!'));
const valeExcludes = valePathLines.filter(p => p.startsWith('!')).map(p => p.slice(1));
const matchesVale = (filename) => {
const matchesGlob = (f, pattern) => {
if (pattern.endsWith('/**')) return f.startsWith(pattern.slice(0, -3) + '/');
if (pattern.endsWith('/*')) {
const dir = pattern.slice(0, -2);
return f.startsWith(dir + '/') && !f.slice(dir.length + 1).includes('/');
}
return f === pattern;
};
const included = valeIncludes.length === 0 || valeIncludes.some(p => matchesGlob(filename, p));
const excluded = valeExcludes.some(p => matchesGlob(filename, p));
return included && !excluded;
Expand Down
Loading