Skip to content

Bump OpenTelemetry SDK to 1.41.1/0.62b1#546

Merged
xrmx merged 4 commits into
mainfrom
bump-sdk-1411
May 20, 2026
Merged

Bump OpenTelemetry SDK to 1.41.1/0.62b1#546
xrmx merged 4 commits into
mainfrom
bump-sdk-1411

Conversation

@xrmx
Copy link
Copy Markdown
Member

@xrmx xrmx commented May 18, 2026

What does this pull request do?

Usual rebase on top of newer SDK. This required a bunch of updated regarding some type changes around the TracerConfigurator and the usual metrics change thanks to the SDK health metrics. While at it also run tests on Python 3.14.

Related issues

Closes #527

@xrmx xrmx requested review from a team as code owners May 18, 2026 14:26
This required a bunch of updated regarding some type changes around the
TracerConfigurator and the usual metrics change thanks to the SDK health
metrics.
@xrmx xrmx force-pushed the bump-sdk-1411 branch from f12d923 to 961062a Compare May 18, 2026 14:28
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: e3222e87-7ede-4a47-9421-dc903ee30a25

📥 Commits

Reviewing files that changed from the base of the PR and between 803c2a3 and 3b214b3.

📒 Files selected for processing (1)
  • src/elasticotel/sdk/trace/tracer_configurator.py

📝 Walkthrough

Walkthrough

This PR upgrades OpenTelemetry packages to 1.41.1/0.62b1 across dependency files, adds Python 3.14 to CI, and removes the boto instrumentation entry. The tracer configurator is refactored to subclass upstream _RuleBasedTracerConfigurator, adopt ConfiguratorRulesT typing, add rules_changed(...) for change detection, and remove prior caching behavior; config and tests are updated to match these changes, and integration tests now expect additional OTel processor metrics.

Possibly related PRs

  • elastic/elastic-otel-python#546: Applies the same tracer configurator rule-typing and rule-change-detection refactor (including removal of update_rules and cache changes) as this PR.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed PR successfully addresses issue #527 by updating tracer configurator to use upstream's RuleBasedConfigurator, adapting argument names, and aligning type signatures.
Out of Scope Changes check ✅ Passed All changes are scoped to SDK/instrumentation version bumps and required code adjustments; no unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-sdk-1411
  • 🛠️ Update Documentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

So we don't need to override the change the return type of a method. So
make the code robust against upstream that does not provide that method.
@xrmx xrmx force-pushed the bump-sdk-1411 branch from 32f9ead to 3decade Compare May 18, 2026 15:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

🔍 Preview links for changed docs

⏳ Building and deploying preview... View progress

This comment will be updated with preview links when the build is complete.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

Copy link
Copy Markdown
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/elasticotel/sdk/trace/tracer_configurator.py Outdated
@xrmx xrmx enabled auto-merge (squash) May 20, 2026 07:50
@xrmx xrmx merged commit b6a0ca5 into main May 20, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise tracer configurator after rebase on top of 1.41.0

3 participants