Skip to content

Bump GCP resource detector to latest#547

Merged
xrmx merged 2 commits into
mainfrom
bump-gcp-resourcedetector
May 20, 2026
Merged

Bump GCP resource detector to latest#547
xrmx merged 2 commits into
mainfrom
bump-gcp-resourcedetector

Conversation

@xrmx
Copy link
Copy Markdown
Member

@xrmx xrmx commented May 19, 2026

What does this pull request do?

Bump GCP resource detector so we can drop our own entry point.

Related issues

So we can drop our own entry point.
@xrmx xrmx requested review from a team as code owners May 19, 2026 07:36
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

🔍 Preview links for changed docs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: ccdac0ea-11d0-4b2e-afe8-5dca3216371b

📥 Commits

Reviewing files that changed from the base of the PR and between 0e3fd4a and f7bac6b.

📒 Files selected for processing (3)
  • dev-requirements.txt
  • pyproject.toml
  • tests/distro/test_distro.py
✅ Files skipped from review due to trivial changes (2)
  • tests/distro/test_distro.py
  • dev-requirements.txt

📝 Walkthrough

Walkthrough

This PR upgrades the OpenTelemetry GCP resource detector library from version 1.8.0a0 to 1.12.0a0 and replaces the internal placeholder identifier _gcp with the new official gcp_resource_detector throughout the codebase. The entry-point in pyproject.toml that mapped _gcp is removed, detector constants are updated with the new name, and all corresponding tests and documentation are adjusted to match.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-gcp-resourcedetector
  • 🛠️ Update Documentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 886f4ad5-4dcf-4fe7-afa8-cdb65ecae3fa

📥 Commits

Reviewing files that changed from the base of the PR and between c44bd8b and 0e3fd4a.

📒 Files selected for processing (6)
  • dev-requirements.txt
  • docs/reference/edot-python/configuration.md
  • pyproject.toml
  • src/elasticotel/distro/resource_detectors.py
  • tests/distro/test_distro.py
  • tests/distro/test_resource_detectors.py

Comment thread pyproject.toml
Comment thread docs/reference/edot-python/configuration.md
@xrmx xrmx merged commit 3666a9f into main May 20, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants