distro: handle opentelemetry-instrumentation-logging LoggingHandler as the sdk one#552
distro: handle opentelemetry-instrumentation-logging LoggingHandler as the sdk one#552xrmx wants to merge 2 commits into
Conversation
…s the sdk one With recent releases the opentelemetry-instrumentation-logging LoggingHandler is used if installed and so we need to consider that as well when deciding to propagate.
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds conditional import handling and fallback logic for LoggingHandler to support both the instrumentation package and SDK implementations. The config.py propagate determination now checks for both handler types. Test coverage is expanded with a new test for the SDK handler scenario and skipIf guards for the instrumentation-dependent test. Development dependencies are updated (certifi, wrapt, opentelemetry-instrumentation-logging) and pyproject.toml dev dependencies are reformatted from single-line to multi-line structure. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this pull request do?
With recent releases the opentelemetry-instrumentation-logging LoggingHandler is used if installed and so we need to consider that as well when deciding to propagate.
Related issues
Closes #551