Fixing integration url.full missing from fortigate#18185
Open
qcorporation wants to merge 4 commits intomainfrom
Open
Fixing integration url.full missing from fortigate#18185qcorporation wants to merge 4 commits intomainfrom
qcorporation wants to merge 4 commits intomainfrom
Conversation
Contributor
Vale Linting ResultsSummary: 5 warnings, 3 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/fortinet_fortigate/docs/README.md | 855 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/fortinet_fortigate/docs/README.md | 855 | Elastic.DontUse | Don't use 'and/or'. |
| packages/fortinet_fortigate/docs/README.md | 859 | Elastic.DontUse | Don't use 'just'. |
| packages/fortinet_fortigate/docs/README.md | 861 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/fortinet_fortigate/docs/README.md | 862 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
💡 Suggestions (3)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/fortinet_fortigate/docs/README.md | 855 | Elastic.Wordiness | Consider using 'sometimes' instead of 'In some cases'. |
| packages/fortinet_fortigate/docs/README.md | 855 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
| packages/fortinet_fortigate/docs/README.md | 859 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
🚀 Benchmarks reportTo see the full report comment with |
Contributor
Author
|
/test |
💚 Build Succeeded
|
| tag: set_url_full_without_query_3f3ba2f9 | ||
| field: url.full | ||
| value: "{{{url.scheme}}}://{{{url.domain}}}{{{url.path}}}" | ||
| if: ctx?.url?.scheme != null && ctx?.url?.domain != null && ctx?.url?.path != null && ctx?.url?.full == null && ctx?.url?.query == null |
Contributor
There was a problem hiding this comment.
Suggested change
| if: ctx?.url?.scheme != null && ctx?.url?.domain != null && ctx?.url?.path != null && ctx?.url?.full == null && ctx?.url?.query == null | |
| if: ctx.url?.scheme != null && ctx.url.domain != null && ctx.url.path != null && ctx.url.full == null && ctx.url.query == null |
| tag: set_url_full_with_query_0d8b7ec0 | ||
| field: url.full | ||
| value: "{{{url.scheme}}}://{{{url.domain}}}{{{url.path}}}?{{{url.query}}}" | ||
| if: ctx?.url?.scheme != null && ctx?.url?.domain != null && ctx?.url?.path != null && ctx?.url?.full == null && ctx?.url?.query != null |
Contributor
There was a problem hiding this comment.
Suggested change
| if: ctx?.url?.scheme != null && ctx?.url?.domain != null && ctx?.url?.path != null && ctx?.url?.full == null && ctx?.url?.query != null | |
| if: ctx.url?.scheme != null && ctx.url.domain != null && ctx.url.path != null && ctx.url.full == null && ctx.url.query != null |
| tag: set_url_full_with_query_ff61f80b | ||
| field: url.full | ||
| value: "{{{url.scheme}}}://{{{url.domain}}}{{{url.path}}}?{{{url.query}}}" | ||
| if: ctx.url?.scheme != null && ctx.url?.domain != null && ctx.url?.path != null && ctx.url?.full == null && ctx.url?.query != null |
Contributor
There was a problem hiding this comment.
Suggested change
| if: ctx.url?.scheme != null && ctx.url?.domain != null && ctx.url?.path != null && ctx.url?.full == null && ctx.url?.query != null | |
| if: ctx.url?.scheme != null && ctx.url.domain != null && ctx.url.path != null && ctx.url.full == null && ctx.url.query != null |
| tag: set_url_full_without_query_0a3eb6ad | ||
| field: url.full | ||
| value: "{{{url.scheme}}}://{{{url.domain}}}{{{url.path}}}" | ||
| if: ctx.url?.scheme != null && ctx.url?.domain != null && ctx.url?.path != null && ctx.url?.full == null && ctx.url?.query == null |
Contributor
There was a problem hiding this comment.
Suggested change
| if: ctx.url?.scheme != null && ctx.url?.domain != null && ctx.url?.path != null && ctx.url?.full == null && ctx.url?.query == null | |
| if: ctx.url?.scheme != null && ctx.url.domain != null && ctx.url.path != null && ctx.url.full == null && ctx.url.query == null |
Comment on lines
+3772
to
+3775
| ], | ||
| "url": { | ||
| "scheme": "https" | ||
| } |
Contributor
There was a problem hiding this comment.
url.scheme with nothing else seems odd. The event has to do with certificates, not a URL, so I'm not sure we should have this? network.protocol is set to https, which I think is good enough.
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Populate url.full when the individual URL components (url.scheme, url.domain, url.path, url.query) are present but url.full is missing. This enables detection rules like Threat Indicator URL Match that rely on url.full for indicator comparison.
WHAT
WHY:
Fortigate logs parse url.domain, url.path, and url.scheme individually but never assembled url.full. The Elastic detection rule "Threat Indicator URL Match" compares indicators against url.full, so FortiGate events were invisible to that rule. The approach follows the same pattern the issue reporter validated in their custom pipeline.
Checklist
changelog.ymlfile.Related issues