Skip to content

[Discover][Metrics] Fix chart panels rendering above push flyout in fullscreen#260127

Merged
justinkambic merged 4 commits intoelastic:mainfrom
justinkambic:260087-chart-flyout-zindex-v2
Mar 31, 2026
Merged

[Discover][Metrics] Fix chart panels rendering above push flyout in fullscreen#260127
justinkambic merged 4 commits intoelastic:mainfrom
justinkambic:260087-chart-flyout-zindex-v2

Conversation

@justinkambic
Copy link
Copy Markdown
Contributor

Summary

Fixes #260087

In the fullscreen metrics view, hovering over a chart panel caused it to render on top of the metric insights flyout. This happened because:

  • The metric insights flyout uses EuiFlyout with type="push", which renders inline (no portal), so the flyout lives inside the fullscreen metrics grid's stacking context
  • The presentation panel hover styles elevate .embPanel to euiTheme.levels.menu, which is higher than the flyout's z-index within that same stacking context

The fix resets .embPanel z-index to auto inside the fullscreen grid class, preventing chart panels from stacking above the push flyout on hover.

Test plan

  • Open Discover with a data view that has metric fields
  • Switch to the Metrics tab and enter fullscreen mode
  • Click "View details" on a chart to open the metric insights flyout
  • Hover over other chart panels and verify they do not render above the flyout
  • Verify chart hover actions (toolbar buttons) still appear correctly within the chart area
  • Exit fullscreen and verify normal chart hover behavior is unaffected

Examples

Before

20260327203329

After

20260327204555

@justinkambic justinkambic self-assigned this Mar 28, 2026
@justinkambic justinkambic requested a review from a team as a code owner March 28, 2026 00:46
@justinkambic justinkambic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:obs-exploration Observability Exploration team v9.4.0 labels Mar 28, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-exploration-team (Team:obs-exploration)

@justinkambic justinkambic changed the title [Metrics] Fix chart panels rendering above push flyout in fullscreen [Discover][Metrics] Fix chart panels rendering above push flyout in fullscreen Mar 30, 2026
Copy link
Copy Markdown
Contributor

@lucaslopezf lucaslopezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could we add a test to avoid regressions?

@justinkambic justinkambic requested a review from a team as a code owner March 31, 2026 18:16
@botelastic botelastic Bot added the Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation label Mar 31, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

…llscreen

EUI push flyouts render inline (no portal), so the flyout lives inside
the fullscreen metrics grid stacking context. The presentation panel
hover styles elevate `.embPanel` to `euiTheme.levels.menu`, which is
higher than the flyout z-index within the same context. Reset chart
panel z-index to `auto` in fullscreen to prevent this overlap.
The `.embPanel__hoverActions` toolbar is a sibling of `.embPanel` and
gets its own z-index elevation on hover, causing it to render above the
push flyout in the same stacking context.
Setting hover actions to z-index auto caused them to clip under charts
in adjacent grid rows. Give them a z-index just below the push flyout
level so they float above neighboring charts but stay behind the flyout.
@justinkambic justinkambic force-pushed the 260087-chart-flyout-zindex-v2 branch from d03e747 to 3c1184d Compare March 31, 2026 18:21
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented Mar 31, 2026

Approvability

Verdict: Needs human review

This PR bundles a small z-index bug fix with a substantial new feature (service badge navigation in APM waterfall). It also includes suspicious files: delete.json contains what appears to be API credentials, and ISSUE_ANALYSIS.md appears to be internal notes. The author does not own any of the changed files, which are owned by obs-presentation-team and obs-exploration-team who should review.

You can customize Macroscope's approvability policy. Learn more.

@justinkambic justinkambic removed the request for review from a team March 31, 2026 19:27
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 1.6MB 1.6MB +107.0B

History

cc @justinkambic

@justinkambic justinkambic merged commit 4b8745f into elastic:main Mar 31, 2026
21 checks passed
@justinkambic justinkambic deleted the 260087-chart-flyout-zindex-v2 branch March 31, 2026 20:19
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Apr 1, 2026
…fullscreen (elastic#260127)

## Summary
Fixes elastic#260087
In the fullscreen metrics view, hovering over a chart panel caused it to
render on top of the metric insights flyout. This happened because:
- The metric insights flyout uses `EuiFlyout` with `type="push"`, which
renders inline (no portal), so the flyout lives inside the fullscreen
metrics grid's stacking context
- The presentation panel hover styles elevate `.embPanel` to
`euiTheme.levels.menu`, which is higher than the flyout's z-index within
that same stacking context

The fix resets `.embPanel` z-index to `auto` inside the fullscreen grid
class, preventing chart panels from stacking above the push flyout on
hover.
## Test plan
- Open Discover with a data view that has metric fields
- Switch to the Metrics tab and enter fullscreen mode
- Click "View details" on a chart to open the metric insights flyout
- Hover over other chart panels and verify they do not render above the
flyout
- Verify chart hover actions (toolbar buttons) still appear correctly
within the chart area
- Exit fullscreen and verify normal chart hover behavior is unaffected  

### Examples

#### Before


![20260327203329](https://github.com/user-attachments/assets/df0dce6c-9346-444a-8647-e1ef506f8949)

#### After


![20260327204555](https://github.com/user-attachments/assets/d1e16b78-87e4-4831-a8cb-444333595053)
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Apr 2, 2026
…fullscreen (elastic#260127)

## Summary
Fixes elastic#260087
In the fullscreen metrics view, hovering over a chart panel caused it to
render on top of the metric insights flyout. This happened because:
- The metric insights flyout uses `EuiFlyout` with `type="push"`, which
renders inline (no portal), so the flyout lives inside the fullscreen
metrics grid's stacking context
- The presentation panel hover styles elevate `.embPanel` to
`euiTheme.levels.menu`, which is higher than the flyout's z-index within
that same stacking context

The fix resets `.embPanel` z-index to `auto` inside the fullscreen grid
class, preventing chart panels from stacking above the push flyout on
hover.
## Test plan
- Open Discover with a data view that has metric fields
- Switch to the Metrics tab and enter fullscreen mode
- Click "View details" on a chart to open the metric insights flyout
- Hover over other chart panels and verify they do not render above the
flyout
- Verify chart hover actions (toolbar buttons) still appear correctly
within the chart area
- Exit fullscreen and verify normal chart hover behavior is unaffected  

### Examples

#### Before


![20260327203329](https://github.com/user-attachments/assets/df0dce6c-9346-444a-8647-e1ef506f8949)

#### After


![20260327204555](https://github.com/user-attachments/assets/d1e16b78-87e4-4831-a8cb-444333595053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-exploration Observability Exploration team Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics][Discover] Chart card overlaps insights flyout on hover

3 participants