generator: non-collinear fire-beacon fields (dress_focal v2 + beacon-geometry bar, #1618)#1621
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…geometry bar, #1618) The dwing recovery proved the focal braziers double as plate-registration beacons. Two braziers on the same row are a collinear pair, blind to vertical scale in the 2-point similarity fit (room_1: 0.07-cell beacon error beside ~1.5 cells of wall misfit — plate unfixable by warping). dress_focal v2: after the door-count plan lands its two lane/shrine braziers, author a THIRD fire beacon (corner watch-brazier) at the connectivity-safe cell that maximises the three-beacon triangle area — deterministic, reusing the existing candidate/landing-exclusion/flood-fill machinery. check_dressing_bars gains a third bar: >=3 fire-kind props with best triangle area >= 2.0 cell^2, or fail loud (beacon-geometry class). --allow-undressed still skips all bars. Tests: every committed wing room now carries 3 fire beacons (areas 12/5/11); the bar unit-tested on 2-fire, 3-collinear, 3-non-collinear geos; existing dressing-bar test updated for the third bar. Refs #1618 (lands after #1611).
1ee49c6 to
ff4091c
Compare
evaOS review status: completedPR: #1621 - generator: non-collinear fire-beacon fields (dress_focal v2 + beacon-geometry bar, #1618) evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #1621 Review URL: #1621 (review) |
![evaos-code-review-bot[bot]](https://avatars.githubusercontent.com/in/4184532?s=60&v=4){kind=small}
There was a problem hiding this comment.
Walkthrough
PR: #1621 - generator: non-collinear fire-beacon fields (dress_focal v2 + beacon-geometry bar, #1618)
Head: ff4091ca37c571d98c5223e3932f5203ce5d0804 into main. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 1/5 (~12 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
qa/test_generate_town.py |
modified | +58/-8 | Test coverage | Low |
Review Signal
No validated inline findings.
Dropped findings before posting: 0. High-severity findings: 0.
Risk Taxonomy
No finding categories.
Validation and Proof
1 required validation/proof recommendation(s) selected from changed files.
- required: Unity editor or Play Mode smoke - WorldOS repo profile implies Unity runtime risk. Proof: Unity editor smoke; Play Mode log; scene/prefab screenshot or recording.
Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
Profile validation hints: Prefer correctness, persistence, CI, release, and regression findings over style-only feedback.
Profile proof expectations: Look for Unity editor, play-mode, fixture, or focused smoke evidence when runtime behavior changes.
Related Context
Related issues/PRs: #1618, #1611.
Suggested labels: tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
Assets/**- Prioritize scene, prefab, save-state, asset-reference, and gameplay regressions. - Path instructions:
ProjectSettings/**- Treat build, platform, input, graphics, and release behavior changes as high risk. - Label suggestions: unity, gameplay, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
1 participant
What & why (#1618)
The dwing recovery (2026-07-16) proved the focal braziers double as plate-registration beacons: a 2-point similarity solve+warp corrected room_0 from 1.66 → 0.17 cells. It also found the limit — room_1's two braziers flank the lane on the same row, a collinear pair that is blind to vertical scale, so a 0.07-cell beacon error coexisted with ~1.5 cells of bottom-wall misfit (plate unfixable by warping). Beacon geometry is part of room design.
This is the generator half of #1618 (no rendering/painting).
Changes
dress_focalv2 (tools/dungen_to_fixtures.py): after the door-count plan lands its two lane/shrine braziers, author a third fire beacon (a corner watch-brazier) at the connectivity-safe cell that maximises the three-beacon triangle area. Deterministic (max-area, ties by row/col), reusing the existing candidate + landing-exclusion + flood-fill connectivity machinery. Narrative plans (dead-end altar+braziers; lane flank; hub crossing) unchanged.check_dressing_barsthird bar: rooms must carry ≥3 fire-kind props (brazier/campfire) whose best triangle area ≥ 2.0 cell², else fail loud (beacon-geometry class).--allow-undressedstill skips all bars. Fire counts only fire kinds — analtaris a focal mass but casts no fire blob.qa/test_generate_town.py): every committed wing room now asserted to carry ≥3 fire beacons with triangle area ≥ 2.0; the bar unit-tested on crafted geos (2 fire → fail; 3 collinear → fail; 3 non-collinear → pass); the existingtest_dressing_bars_fail_loud…updated faithfully for the third bar.Evidence — end-to-end regen (exit 0)
generate_town.py … --rooms room_0,room_1,room_2 --town-id dwing --material stone→ exit 0 with the new bars enforced. Per-room prop-kind counts + fire triangle areas:All three rooms:
check_dressing_barsempty (green).Tests
uv run --directory servers/engine --group dev python -m pytest qa/test_generate_town.py -q -p no:xdist→ 13 passed.Sequencing
Based on
focal-dressing(PR #1611, which introducesdress_focalv1 +check_dressing_bars). Lands after #1611; retarget base tomainonce #1611 merges.