Skip to content

test(incremental): add crash-recovery subprocess harness#67

Open
100yenadmin wants to merge 1 commit into
reconcile/r06-file-node-fallbackfrom
reconcile/r07-large-incremental-harness
Open

test(incremental): add crash-recovery subprocess harness#67
100yenadmin wants to merge 1 commit into
reconcile/r06-file-node-fallbackfrom
reconcile/r07-large-incremental-harness

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Summary

  • add a real child-process harness for a 61-file incremental repository
  • exercise add, edit, rename, delete, importer closure, and the >50%/50-file escalation valve
  • terminate after the persisted effective-write-set marker and require clean dirty-state recovery
  • fail closed on timeout, signal, non-zero exit, missing metadata/database, empty graph, or stuck dirty marker
  • retain graph, embeddings, FTS/vector capability, write-set, exit, and sidecar evidence
  • register the harness once in the sequential native-Ladybug project and in the Windows/macOS subset

Local Proof

  • test-first missing-runner failure observed
  • corrected native subprocess cycle passed twice on macOS ARM
  • final sequential-project run passed in 242.94 seconds
  • recovery produced complete live embeddings at 384 dimensions
  • deleted and renamed pre-change embedding IDs remained absent
  • forced-rebuild graph statistics and embedding IDs matched recovery output
  • typecheck, formatting, and diff checks passed

CI Boundary

  • Ubuntu runs through the sharded full suite
  • Windows and macOS run through the platform-sensitive matrix
  • the child performs no extension installation or network access
  • no live registry or live index is used

Evidence: /Volumes/LEXAR/Codex/session-notes/2026-07-13/gitnexus-fork-upstream-reconciliation/r07-large-incremental-harness.md

Fixes #46

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 948a5692-c7e5-4438-af72-1fa245ed320e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reconcile/r07-large-incremental-harness

Comment @coderabbitai help to get the list of available commands.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #67 - test(incremental): add crash-recovery subprocess harness
Head: f5357e1afcd45cb29456f731ba9ad11fa169e1eb
Updated: 2026-07-13T11:33:40.555Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #67

Review URL: #67 (review)

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #67 - test(incremental): add crash-recovery subprocess harness
Head: f5357e1afcd45cb29456f731ba9ad11fa169e1eb into reconcile/r06-file-node-fallback. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 2. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #46.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

@100yenadmin 100yenadmin force-pushed the reconcile/r06-file-node-fallback branch from 29bf9b9 to 7663bcc Compare July 13, 2026 12:25
@100yenadmin 100yenadmin force-pushed the reconcile/r07-large-incremental-harness branch from f5357e1 to 22055c6 Compare July 13, 2026 12:25
@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: failed

PR: #67 - test(incremental): add crash-recovery subprocess harness
Head: 22055c6aa5dab2422c297030bfd4c13f77e5bdaa
Updated: 2026-07-13T13:07:51.362Z

evaOS review failed for this head and needs retry or operator attention.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #67

Details: Review failed; see bot evidence for operator-only details.

@github-actions

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14536 14474 0 62 21s

✅ All 14474 tests passed

62 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.69% 53909/66802 N/A% 🟢 ████████████████░░░░
Branches 67.7% 32918/48618 N/A% 🟢 █████████████░░░░░░░
Functions 86.73% 6213/7163 N/A% 🟢 █████████████████░░░
Lines 84.23% 48089/57092 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant