Skip to content

test(incremental): prove FTS deletion recovery#71

Open
100yenadmin wants to merge 1 commit into
reconcile/r08-nodebatch-dispositionfrom
reconcile/r09-fts-disposition
Open

test(incremental): prove FTS deletion recovery#71
100yenadmin wants to merge 1 commit into
reconcile/r08-nodebatch-dispositionfrom
reconcile/r09-fts-disposition

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Summary

  • require the large incremental child to load a preinstalled FTS extension without network installation
  • exercise a below-threshold rename/edit while FTS indexes are active
  • require query hits after the small incremental, dirty recovery, and force comparison
  • retain the existing finalization path without adding the historical drop-before-delete workaround

Evidence

  • red: policy never prevented preinstalled FTS loading and the new gate failed closed
  • green post-recovery queryability: 1/1 passed in 194.41 seconds
  • tightened active-FTS deletion and full recovery contract: 1/1 passed in 284.92 seconds
  • TypeScript no-emit passed
  • Prettier passed
  • GitNexus detect_changes was attempted with the explicit worktree and safely refused because the registered MCP repository is a different canonical clone; no index refresh was performed

Scope

Test harness only. No production FTS behavior, embeddings, live indexes, tags, packages, releases, or runtime deployments are changed.

Tracks #48. Dispositions #38 after current-head CI is green.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 551e052b-e8f7-4584-99df-6d7a030e5618

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reconcile/r09-fts-disposition

Comment @coderabbitai help to get the list of available commands.

@100yenadmin 100yenadmin force-pushed the reconcile/r08-nodebatch-disposition branch from 670f4d8 to f767e35 Compare July 13, 2026 12:25
@100yenadmin 100yenadmin force-pushed the reconcile/r09-fts-disposition branch from 99a7107 to 342abaa Compare July 13, 2026 12:25
@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: failed

PR: #71 - test(incremental): prove FTS deletion recovery
Head: 342abaa86047291e6d27470dd71b1ff652863f42
Updated: 2026-07-13T12:59:05.353Z

evaOS review failed for this head and needs retry or operator attention.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #71

Details: Review failed; see bot evidence for operator-only details.

@github-actions

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14537 14475 0 62 20s

✅ All 14475 tests passed

62 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.68% 53897/66802 N/A% 🟢 ████████████████░░░░
Branches 67.69% 32913/48618 N/A% 🟢 █████████████░░░░░░░
Functions 86.69% 6210/7163 N/A% 🟢 █████████████████░░░
Lines 84.2% 48077/57092 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant