Skip to content

feat(mcp): normalize impact and context aliases#73

Open
100yenadmin wants to merge 1 commit into
reconcile/r10-preservation-contractfrom
reconcile/r11-mcp-parameter-aliases
Open

feat(mcp): normalize impact and context aliases#73
100yenadmin wants to merge 1 commit into
reconcile/r10-preservation-contractfrom
reconcile/r11-mcp-parameter-aliases

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Tracks #50.

Contract

  • Normalize impact.target, impact.name, and impact.symbol once at the MCP dispatch boundary.
  • Normalize context.file_path and context.file at the same boundary.
  • Allow agreeing trimmed values; return a validation error for conflicts before repository resolution or local/group dispatch.
  • Remove alias keys before downstream dispatch so every backend consumes canonical parameters only.
  • Advertise compatibility aliases in MCP schemas; strict impact clients may satisfy an anyOf target constraint with any supported key.

Evidence

  • TDD red/green proof across schema, local dispatch, conflict rejection, and @group forwarding.
  • 248 tool-schema and dispatch unit tests passed.
  • 34 real LadybugDB backend integration tests passed, including three alias-specific cases.
  • Typecheck, formatting, diff integrity, and targeted lint with zero errors passed.

Retained evidence: /Volumes/LEXAR/Codex/session-notes/2026-07-13/gitnexus-fork-upstream-reconciliation/r11-mcp-parameter-aliases.md.

Boundaries

  • One capability commit over R10.
  • The stale registered GitNexus index was not refreshed or repointed.
  • No live-index mutation, publication, runtime rollout, or fork main mutation.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8cfb828b-8ebf-457e-bca1-e4ce4a867b60

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch reconcile/r11-mcp-parameter-aliases

Comment @coderabbitai help to get the list of available commands.

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #73 - feat(mcp): normalize impact and context aliases
Head: 461079c25ffb4b5b0545aba7bb9e939a90712d6d
Updated: 2026-07-13T13:11:49.117Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #73

Review URL: #73 (review)

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14562 14500 0 62 20s

✅ All 14500 tests passed

62 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.7% 54020/66935 N/A% 🟢 ████████████████░░░░
Branches 67.73% 33033/48768 N/A% 🟢 █████████████░░░░░░░
Functions 86.76% 6227/7177 N/A% 🟢 █████████████████░░░
Lines 84.22% 48192/57216 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #73 - feat(mcp): normalize impact and context aliases
Head: 461079c25ffb4b5b0545aba7bb9e939a90712d6d into reconcile/r10-preservation-contract. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 0. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #50.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant