Skip to content

ci: bump electron/semantic-trusted-release to v1.1.2 - #150

Merged
MarshallOfSound merged 2 commits into
mainfrom
ci/semantic-trusted-release-v1.1.1
Oct 22, 2026
Merged

MarshallOfSound merged 2 commits into
mainfrom
ci/semantic-trusted-release-v1.1.1

Conversation

@claude

@claude claude Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Keeley Hammond · Slack thread

The release action pinned here ran the npm publish step on Node 24.10.0, which predates the October 2026 Node.js security release. v1.1.2 tracks the latest Node 24.x via check-latest, so future Node patch releases need no further pin bumps.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EvByZWibvh3yPk8R9FdxyN
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 04:10

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and didn't find any bugs. A human should still confirm that the new SHA is the actual v1.1.1 release before merging. This action runs in the npm publishing job, which has id-token: write and the GitHub app token, and I couldn't check the SHA against the upstream tag from this checkout.

What was reviewed:

  • The one-line change in .github/workflows/release.yml bumps electron/semantic-trusted-release from 0351784… (v1.1.0) to 2a7b16d… (v1.1.1).
  • The action is still pinned to a full commit SHA with a version comment. The github-token input and the job's permissions and environment are unchanged.
  • Not checked: whether 2a7b16df83a1f77339ad473654c5fbd2b32b193b is the commit the upstream v1.1.1 tag points to, and what changed in the action between the two versions.
Extended reasoning...

The PR changes one line in the release workflow: it moves the pinned commit SHA of electron/semantic-trusted-release, the action that publishes to npm. It touches the supply chain: that job runs in the npm-trusted-publisher environment with id-token write and a GitHub app token. The SHA could not be checked against the upstream v1.1.1 tag from this shallow, offline checkout. CODEOWNERS assigns every path to the ecosystem working group, so this should not be auto-approved.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EvByZWibvh3yPk8R9FdxyN
@claude claude Bot changed the title ci: bump electron/semantic-trusted-release to v1.1.1 ci: bump electron/semantic-trusted-release to v1.1.2 Oct 22, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the latest push and found no bugs. A human should still confirm the new pin, because this action runs in the npm publish job and I couldn't check the SHA against the upstream tag from here.

What was reviewed:

  • The one-line change in .github/workflows/release.yml: electron/semantic-trusted-release moves from the v1.1.0 SHA to 672a62fe17fce21a0d10de5a6825ee54817af317, labelled # v1.1.2. It is still a full 40-character SHA, and the github-token input is unchanged.
  • The PR title and description still say v1.1.1, but the latest commit pins v1.1.2. Please check that the SHA really is the v1.1.2 tag and update the title to match.
Extended reasoning...

The change replaces one action SHA in the release workflow. That job has id-token: write, runs in the npm-trusted-publisher environment and receives a GitHub App token, so whatever code the pin points to is supply-chain-sensitive. .github/CODEOWNERS assigns every path to the ecosystem working group, which rules out auto-approval. The new SHA couldn't be resolved to the upstream v1.1.2 tag from this shallow checkout. The PR title also still says v1.1.1, which doesn't match the pinned code.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 05:43
@MarshallOfSound
MarshallOfSound merged commit f80508a into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the ci/semantic-trusted-release-v1.1.1 branch October 22, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants