Skip to content

ci: bump electron/secret-service-action to v1.1.0 - #151

Merged
MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0
Oct 22, 2026
Merged

MarshallOfSound merged 1 commit into
mainfrom
bump-secret-service-action-v1.1.0

Conversation

@claude

@claude claude Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Samuel Attard · Slack thread

Bumps secret-service-action to v1.1.0, which points the secret exchange at secret-service's new home on ionic (secret-service.electronjs.org) instead of Heroku.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELojQikqpZ2KVGqjEeNwUe
@claude
claude Bot requested a review from a team as a code owner October 22, 2026 21:37

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR and found no bugs. The diff is a one-line pin bump, but the action it changes fetches the secrets the release job publishes with. A human should still confirm that 23b9042f797e34674f0fe2c91608f57f9661ccf2 really is the v1.1.0 tag of electron/secret-service-action.

What was reviewed:

  • The diff changes only the commit pin for the "Get GitHub app token" step. The action stays pinned to a full SHA with a version comment, matching the other steps.
  • The next step reads fromJSON(steps.secret-service.outputs.secrets).GITHUB_TOKEN, so v1.1.0 has to keep the secrets output in the same shape. I couldn't check this or the tag SHA from this shallow checkout.
Extended reasoning...

The change edits one line in .github/workflows/release.yml: it moves the electron/secret-service-action pin from the v1.0.0 SHA to a SHA labeled v1.1.0. That step supplies the GitHub token to semantic-trusted-release in a job with id-token: write that publishes to npm, so it touches the release secret-handling path. CODEOWNERS assigns every file to the ecosystem working group. The new SHA and the action's output contract couldn't be checked against upstream from here. These facts are why a human should take a look instead of the PR getting an automatic approval.

@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) October 22, 2026 21:42
@MarshallOfSound
MarshallOfSound merged commit 6e2d7a7 into main Oct 22, 2026
11 checks passed
@MarshallOfSound
MarshallOfSound deleted the bump-secret-service-action-v1.1.0 branch October 22, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants