fix: harden minidump parser against malformed inputs#150
Merged
Conversation
format.readMinidump() and its helpers trusted RVAs and header fields without validating them against the buffer size, so unexpected inputs produced ERR_OUT_OF_RANGE from Buffer reads rather than an Error the caller could handle. Add bounds checks at the header, stream directory, and each RVA-consuming helper, and guard moduleList()'s fs.readFile callback with try/catch so parse failures always arrive through the user-supplied callback.
codebytere
force-pushed
the
fix-malformed-issue
branch
from
1e77e75 to
81e1c83
Compare
erickzhao
approved these changes
Apr 20, 2026
|
🎉 This PR is included in version 0.26.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format.readMinidump()and its helpers trusted RVAs and header fields without validating them against the buffer size, so unexpected inputs producedERR_OUT_OF_RANGEfrom Buffer reads rather than an Error the caller could handle.Add bounds checks at the header, stream directory, and each RVA-consuming helper, and guard
moduleList()'sfs.readFilecallback withtry/catchso parse failures always arrive through the user-supplied callback.