Repository navigation
feat: roll rbe-credential-helper releases into build-tools - #223
Merged
Merged
Conversation
On `release.published` from electron/rbe-credential-helper, read the release back until all six platform tarballs are uploaded with a digest, verify each CDN file build-tools downloads hashes to that digest, then open or update a single `roller/rbe-credential-helper/main` PR on electron/build-tools that rewrites CREDENTIAL_HELPER_TAG and every CREDENTIAL_HELPER_SHA256 entry in src/utils/reclient.ts. Releases that are not newer than what build-tools (or the open roll PR) already pins are skipped. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SRpnCfe3GVUxrP8zoGTsVG
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SRpnCfe3GVUxrP8zoGTsVG
MarshallOfSound
marked this pull request as ready for review
October 24, 2026 07:06
MarshallOfSound
approved these changes
Oct 24, 2026
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
VerteDinde
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Samuel Attard 路 Slack thread
This moves the build-tools credential helper bump out of a GitHub Actions job and into roller: on a
release.publishedwebhook from electron/rbe-credential-helper, roller reads the release back until all six platform tarballs are uploaded with a digest, checks that each file build-tools will download from the CDN hashes to that digest (so a missing CDN file like the one that got build-tools#734 reverted never reaches a PR), then opens or updates a singleroller/rbe-credential-helper/mainPR on electron/build-tools that rewrites thetagand all sixsha256entries insrc/utils/rbe-credential-helper.json(plain JSON, so the roll never touches build-tools code), committing through the contents API so GitHub signs it as electron-roller[bot] and skipping releases that are not newer than what main or the open roll PR already pins. For this to fire, the electron-roller App needs to be installed on electron/rbe-credential-helper with Contents read and the Release event subscribed (plus Contents and Pull requests write on electron/build-tools), and this depends on electron/build-tools#923 (which moves the pin out ofreclient.tsinto that JSON file) and electron/rbe-credential-helper#50 (which cuts releases automatically) landing first.Generated by Claude Code