Don't make ItemManager a singleton#551
Closed
leolost2605 wants to merge 2 commits into
Closed
Conversation
zeebok
approved these changes
Mar 9, 2026
zeebok
left a comment
zeebok
left a comment
Contributor
There was a problem hiding this comment.
Code looks fine to me, though I am not sure if there should be any null checks or why it should not a singleton since I am not familiar with the dock code base as much.
Member
Author
|
Since there was a big architecture change since this was proposed superseded by #589. I also added some reasoning there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.