Launcher: Use index for tooltip #590
Merged
Merged
Conversation
danirabbit
approved these changes
Jun 19, 2026
| get { | ||
| var item_group = get_ancestor (typeof (ItemGroup)) as ItemGroup; | ||
| if (item_group == null) { | ||
| return Gtk.INVALID_LIST_POSITION; |
Member
There was a problem hiding this comment.
Nice use of constants, I didn't know about this one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of manually calculating the index use the provided property of base item. Required some refactoring to make sure the index gets updated when it should. This will also make sure update_tooltip is called only once when reordering instead of on every frame like it's currently on main.