UbuntuInstaller: get permission async#214
Merged
Merged
Conversation
danirabbit
changed the title
danirabbit
force-pushed
the
danirabbit/installer-asyncpermissions
branch
from
fa720a5 to
818c316
Compare
ryonakano
reviewed
Jun 22, 2024
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
Oops I thought I got them all. Will fix! |
Member
Author
|
@ryonakano should be fixed now! |
ryonakano
reviewed
Jun 26, 2024
ryonakano
approved these changes
Jun 29, 2024
ryonakano
left a comment
ryonakano
left a comment
Member
There was a problem hiding this comment.
Looks good and works as expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
Fixes #204