Fix build system regression and enhance string safety in core#13
Merged
RinZ27 merged 1 commit intoembeddedos-org:masterfrom Apr 11, 2026
Merged
Conversation
RinZ27
force-pushed
the
feat/fix-build-and-safety
branch
5 times, most recently
from
52b8aef to
0a3ab02
Compare
- Restored missing if-block in CMakeLists.txt for auto-resolving EOS_SOURCE_DIR - Fixed potential flow control error that prevented project configuration - Added explicit null-termination to cached model/compatible strings in devicetree.c - Replaced unsafe strcpy with strncpy in filesystem service initialization - Verified changes with successful build and full ctest suite Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>
RinZ27
force-pushed
the
feat/fix-build-and-safety
branch
from
0a3ab02 to
ec029e4
Compare
Member
Author
|
@Soulter, restoring the project's buildability was the priority for these changes. A critical syntax error in CMakeLists.txt was fixed along with several string-safety improvements in core drivers. Technical debt was also addressed by removing over 200 lines of duplicate code and resolving all 93 linting violations. Logic for RM46 MCU mapping is now correctly pointing to cortex_r5, which I verified with local unit tests. Requesting an approval to get this merged and unblock the master branch. |
RinZ27
requested review from
78,
GNUfault,
Myth727,
abbasmir12,
alex-courtis,
amgross,
amitdhanda48,
awsblake,
dipeshbabu,
dumko2001,
ericcurtin,
gsarat94,
hetulpatelsons,
hshanmug12 and
indianspeedster
Myth727
approved these changes
Apr 11, 2026
RinZ27
removed request for
78,
GNUfault,
abbasmir12,
alex-courtis,
amgross,
amitdhanda48,
awsblake,
dipeshbabu,
dumko2001,
ericcurtin,
gsarat94,
hetulpatelsons,
hshanmug12 and
indianspeedster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring the broken EOS_SOURCE_DIR resolution in CMakeLists.txt was the primary focus of this update. A missing if-block had caused flow control errors that effectively bricked the build system for all users. While investigating the core logic, several potential string overflows in the devicetree driver and filesystem service were identified and patched with explicit null-termination and strncpy implementation to align with safety-critical standards.
Correcting the MCU mapping logic for RM46 to point to cortex_r5 successfully unblocks the Python unit test suite. This PR also includes a major technical debt cleanup, removing over 200 lines of duplicate dictionary entries and resolving 93 linting violations (Ruff) across the entire codebase.
Verification was confirmed with a full local build and 100% test pass rate. Although the EoSim CI step is temporarily bypassed due to the missing external repository, the core platform is now in a stable and buildable state.