Repository navigation
Bump the egui family to 0.37.0 so the main patch applies - #271
Closed
virtualritz wants to merge 1 commit into
Closed
virtualritz wants to merge 1 commit into
virtualritz wants to merge 1 commit into
Conversation
egui main is now 0.37.0 while these requirements still said 0.36.0, and a [patch.crates-io] entry whose source version does not satisfy the requirement is silently ignored -- so the patched main was not in the graph at all and the workspace built against released 0.36. This is the whole reason the patch block exists, so the requirements have to track whatever version main reports. No code changes were needed: egui_plot already compiles against main. Verified: cargo check --workspace, cargo test -p egui_plot (9 passed, 2 ignored) and the doctests; the lock resolves the egui family at 0.37.0.
|
View snapshot changes at kitdiff |
Collaborator
|
Duplicate of #270 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
egui
mainis now 0.37.0, while[workspace.dependencies]still requires0.36.0foregui,eframe,egui_extras,egui_kittestandemath.A
[patch.crates-io]entry whose source version does not satisfy therequirement is silently ignored -- and the
[patch.crates-io]block at thebottom of
Cargo.toml, whose whole purpose is to track eguimain, thereforestopped applying. The workspace was building against released 0.36 instead of
main, with nothing failing to say so.Bumping those five requirements to
0.37.0restores the patch. No codechanges were needed -- egui_plot already compiles against current
main.Verification
cargo check --workspace-- passescargo test -p egui_plot-- 9 passed, 2 ignored; doctests passegui,eframe,egui_extras,egui_kittestandemathat0.37.0This is the same failure mode this repo hits at every egui version bump: the
requirements have to track whatever version
mainreports, or the patch blockquietly stops doing anything.