Add a clean script for local build and runtime artifacts#28
Conversation
|
@Caneryy is attempting to deploy a commit to the emrekayat's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Thanks for the PR for #23. The clean command works locally and the requested checks pass on this branch, but I cannot merge it yet after the latest main update. Current blocker:
Please rebase on latest |
|
Thanks for the focused implementation. I checked this locally from the PR branch as the maintainer account. What passes:
One acceptance gap before merge: the issue/README copy says the command removes local build output Please update
Note: GitHub Actions is currently failing on a Rollup optional dependency install issue ( |
Add a cross-platform Node clean command that removes workspace dist and coverage output plus local API runtime data, and document it in README.
9379437 to
8d4627a
Compare
Keep apps/api/data/.gitkeep after clean, remove only runtime DB/JSON files, and delete root-level dist and coverage directories. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the detailed review @emrekayat — both blockers are addressed. Changes:
Verified locally:
Ready for re-review. |
Summary
npm run cleancommand backed by a small cross-platform Node script.distandcoveragedirectories plus local API runtime files underapps/api/data.Test plan
npm run buildandnpm run test:coverageto generate local artifactsnpm run cleanremovesdist,coverage, andapps/api/dataruntime filesnpm run check:source-artifactspasses after cleanCloses #23