feat(web): add analytics loading and empty states#30
Conversation
Improve dashboard UX before analytics data loads and when no queries have run yet.
|
@Caneryy is attempting to deploy a commit to the emrekayat's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Thanks for the PR for #24. The loading/empty-state behavior looks aligned with the issue, and local typecheck/build pass, but I cannot merge it yet because the formatting gate fails. Local verification:
Please run Prettier on the touched files, push the formatting fix, and rerun |
|
Thanks for the UI pass here. I reviewed the branch locally as the maintainer account. What passes:
Blocker before merge:
Please run Prettier on that file (or
Functional review note: the loading/empty-state approach is in scope for #24 and preserves the populated analytics path. I can re-check quickly once the formatting failure is fixed. CI note: GitHub Actions is also failing on a Rollup optional dependency install issue ( |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the review @emrekayat — formatting fix is pushed.
Ready for re-review whenever you have a moment. |
Summary
Test plan
npm run typechecknpm run buildCloses #24