NXT-573: Added Vite bundler#393
Open
daniel-stoian-lgp wants to merge 20 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Added a complete, opt-in Vite bundler path to
@enact/cli, alongside webpack.The Vite path is only reachable via
--viteorENACT_BUNDLER=vite; both bundlers coexist for the duration of the migration.Every
pack/servefeature is covered:Files:
config/vite.config.js(the port ofwebpack.config.js, same factory signature),commands/vite-utils.js, four docs.commands/pack.js,commands/serve.js,commands/eject.js.config/webpack.config.jsintoconfig/postcss-plugins.js(getPostCssPlugins) so both configs share one copy — same plugin array, same order, no behavior change. This is the only webpack-facing change and the main thing to review.vite,@vitejs/plugin-react,terser,vite-plugin-node-polyfills.Resolution
Validated end-to-end on real apps: Sandstone (React 18, pre-compiled deps) and Limestone (React 19, ships raw
@enactsource with JSX-in-.jsand~npm imports), plusqa-dropdown, the redux sample, and the aggregateall-samples.Validation was done in a real browser, Eight config issues and eight runtime issues were found and fixed; all are documented with root causes in
docs/vite-migration.md.Additional Considerations
How to test:
Links
NXT-573
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)