test(e2e): port sync tests to B2 cursor contract (pairs with plugin #109)#629
Merged
Conversation
…ntract Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the Obsidian E2E suite to the B2 cursor-pull sync contract (plugin PR
engram-app/Engram-obsidian#109). B2 replaced the legacy timestamp feed with an ordered cursor pull, which changes two behaviors these tests asserted:lastSyncis frozen — the opaquesyncCursoris the watermark now, so "lastSync advances after a sync" is obsolete.bootstrap()— afullSyncpush counter can read 0 even though the file reaches the server.Changes:
e2e/helpers/cdp.py— addget_sync_cursor()(readssyncEngine.getSyncCursor()).test_58_commands_palette/test_59_status_bar_click— assert the command/click actually pulls a pending server change (create a server note → run sync-now / click → assert it arrives locally), instead of assertinglastSyncchanged.test_44_oauth_device_flow— assert the created note arrives on the server (the in-fileGET /notes/{path}), instead of asserting thefullSyncpush count ≥ 1.Verification
The paired e2e (this branch + plugin
feat/sync-cursor-pull-b2) is green — run 27667988219: 109 passed. That run also validated the plugin-side B2 fixes (reconnect catch-up after a vault swap; offline-queue recovery).Merge note
This pairs with plugin #109 (chicken-and-egg): these ported tests assert B2 behavior, so they fail against plugin
main(pre-B2). Merge order: plugin #109 first (B2 → plugin main), then this PR — at which point its auto-triggered e2e runs against a B2 plugin main and passes. Detail in workspacedocs/context/b2-cursor-pull-e2e-triage.md.🤖 Generated with Claude Code