Skip to content

fix: fail incomplete pr content fetches #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anderdc merged 1 commit into from
May 14, 2026
Merged

fix: fail incomplete pr content fetches #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/das/src/webhook/github-fetcher.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,10 +380,9 @@ export class GitHubFetcherService implements OnModuleInit {

// 3. Fetch file contents in batches (base + head in one GraphQL call each)
if (!pr.headSha) {
this.logger.warn(
`PR ${repoFullName}#${prNumber} has no head SHA — skipping content fetch`,
throw new Error(
`PR ${repoFullName}#${prNumber} has no head SHA; cannot fetch content`,
);
return;
}

// Prefer merge-base SHA (true common ancestor) over base SHA for
Expand Down Expand Up @@ -507,10 +506,9 @@ export class GitHubFetcherService implements OnModuleInit {
batchSize = newSize;
// Retry same i with smaller batch
} else {
this.logger.warn(
`GraphQL content batch failed at min size ${minBatchSize}: ${err}. Skipping batch.`,
throw new Error(
`GraphQL content batch failed at min size ${minBatchSize}: ${err}`,
);
i += batch.length;
}
}
}
Expand Down
Loading