Skip to content

fix: enqueue PR files refresh on base-branch edits #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakearmstrong59 wants to merge 1 commit into
base: test
Choose a base branch
from
+13 −4
Open

fix: enqueue PR files refresh on base-branch edits #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions packages/das/src/webhook/handlers/pull-request.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,16 @@ export class PullRequestHandler {
);
}

// Enqueue diff fetch on open, push, or merge
// Enqueue diff fetch on open, push, merge, or base retarget
const diffActions = ["opened", "synchronize", "closed"];
const isBaseRetarget = this.isBaseBranchRetargetEdit(action, payload);
const shouldFetchDiff =
diffActions.includes(action) && (action !== "closed" || pr.merged);
isBaseRetarget ||
(diffActions.includes(action) && (action !== "closed" || pr.merged));

if (shouldFetchDiff) {
// Reset scoring flag on new pushes
if (action === "synchronize") {
// Reset scoring flag on new pushes or base retargets
if (action === "synchronize" || isBaseRetarget) {
await this.prRepo.update(
{ repoFullName, prNumber },
{ scoringDataStored: false },
Expand Down Expand Up @@ -117,4 +119,11 @@ export class PullRequestHandler {
);
}
}

private isBaseBranchRetargetEdit(
action: string,
payload: Record<string, any>,
): boolean {
return action === "edited" && payload.changes?.base != null;
}
}