fix(webhook): reconcile repository renames by GitHub id#86
Closed
volcano303 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Not pursuing — repository renames on subnet-tracked repos are vanishingly rare, and if one ever does happen an operator can repair the rows with a one-shot SQL UPDATE per repo-keyed table in less time than reviewing this PR. The cost of automatic reconciliation in the webhook hot path (extra SELECT per event, schema change, +182 lines on the trust surface) outweighs the cost of manual repair on the unlikely day it triggers. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repos.github_repo_idso the mirror can identify repositories by GitHub's stable repository ID.repository.full_namechanged by moving existing repo-keyed mirror rows to the new full name before handler dispatch.Related Issues
Fixes #72
Type of Change
Testing
npm run format:checknpm run lintnpm run buildgit diff --checkChecklist