fix: count ALL open issues for spam multiplier instead of lookback-bounded subset (#929)#1174
Closed
alpurkan17 wants to merge 1 commit into
Closed
fix: count ALL open issues for spam multiplier instead of lookback-bounded subset (#929)#1174alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
Collaborator
|
Duplicate of #930 which is better scoped. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirror issue discovery currently uses the same lookback-bounded
get_miner_issues(since=lookback_date)response for both scoring (correct) and counting open issues for the spam multiplier (incorrect). Open issues created beforePR_LOOKBACK_DAYSare omitted fromtotal_open_issuesand never trigger the open-issue spam gate.This fix adds a second
get_miner_issuescall without the lookback window, then countsOPENissues across mirror-enabled repos from that full response. The scoring path still uses the lookback-bounded list unchanged.If the unfiltered fetch fails, the lookback-bounded count is used as a fallback approximation (previous behavior).
Validation
total_openis derived fromget_miner_issues(github_id)(nosince) — counts ALL open issuestotal_openfalls back to lookback-bounded count if the unfiltered fetch raisesMirrorRequestErrorfilteredlistCloses #929