feat: allocate emissions by repository share#1233
Closed
CaptainTimon wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Closing — contributor is not a registered subnet miner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Folded #1215 into one atomic PR, per maintainer feedback on the sliced PRs.
This converts repository allocation from an unbounded per-PR
weightmultiplier into bounded repo-levelemission_shareallocation:weighttoemission_share, with[0, 1]per-repo validation andsum(emission_share) <= 1.0validation.issue_discovery_share([0, 1], default0.5) and setentrius/oc-1to0.0for issue discovery.OSS_EMISSION_SHARE = 0.90andISSUES_TREASURY_EMISSION_SHARE = 0.10; remove fixed issue-discovery/recycle emission constants.allocate_repo_scoring_pool: each repo receives at mostemission_share * 90%; PR/issue sides split byissue_discovery_share, empty side spills only within the same repo, fully inactive repo slices and registry slack recycle to UID 0.Issueobjects onMinerEvaluation.discovered_issuesso aggregation uses real per-repo issue-discovery evidence, not global normalized arrays.gitt miner scoreto allocate from raw per-repo score evidence.Related Issues
Closes #1215.
Prior PR Analysis
Reviewed the existing single-PR attempts #1217, #1218, #1219, and #1223 plus the closed slice PRs #1220, #1222, #1224-#1232.
This PR keeps the integrated/atomic shape requested by the maintainer, but avoids two risks I saw in those attempts:
repo_weight_multiplierfields stay neutral for compatibility.MinerEvaluation, so repo-level aggregation can see real issue-discovery scores from the active path instead of relying on a non-existent per-repo aggregate field or already-normalized arrays.Type of Change
Emission policy / reward allocation change.
Testing
Commands run:
Results:
195 passed729 passedChecklist