feat: rename RepositoryConfig.weight to emission_share (#1215)#1241
Closed
alpurkan17 wants to merge 8 commits into
Closed
feat: rename RepositoryConfig.weight to emission_share (#1215)#1241alpurkan17 wants to merge 8 commits into
alpurkan17 wants to merge 8 commits into
Conversation
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
4 times, most recently
from
e68078b to
8179d0f
Compare
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
2 times, most recently
from
65c538a to
7dc8a30
Compare
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
from
7dc8a30 to
52b431f
Compare
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
from
5fbcba9 to
efc8287
Compare
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
3 times, most recently
from
cc0372b to
6099a47
Compare
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
from
6099a47 to
b820d20
Compare
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
3 times, most recently
from
cadd39e to
c6315ac
Compare
alpurkan17
force-pushed
the
feat/1215-emission-share
branch
from
c6315ac to
a55a3ab
Compare
Contributor
Author
|
Ready for review. All 11 deliverables from the issue are implemented, CI passes, and the two blockers raised on the competing PR (case sensitivity and collateral subtraction) are already addressed in this implementation. |
Contributor
Author
|
@anderdc @LandynDev PR #1241 ready for review. All 11 deliverables from #1215 implemented, CI passes, and the two blockers identified on the competing PR (case sensitivity and collateral subtraction) are already addressed. |
Contributor
Author
|
Competitor #1235 sudah merged. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
RepositoryConfig.weighttoemission_shareas step 1 of #1215.resolve_repo_weight→resolve_emission_shareDEFAULT_REPO_WEIGHT→DEFAULT_EMISSION_SHAREemission_sharekeyPart of #1215