fix: delegate _resolve_endpoint to resolve_network for consistent precedence (#1198)#1242
Open
alpurkan17 wants to merge 1 commit into
Open
fix: delegate _resolve_endpoint to resolve_network for consistent precedence (#1198)#1242alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
_resolve_endpoint()in miner commands to delegate toresolve_network()from issue_commands instead of duplicating the precedence logic. This fixes the stale ws_endpoint override bug (recognized config network now beats ws_endpoint) and ensures consistent endpoint resolution across all CLI commands.Why this is better
Closes #1198