fix: keep notifications and recovery UI above deep modal stacks (#3095)#3097
Open
JuliaMV wants to merge 1 commit into
Open
fix: keep notifications and recovery UI above deep modal stacks (#3095)#3097JuliaMV wants to merge 1 commit into
JuliaMV wants to merge 1 commit into
Conversation
|
Generated by: track-bundle-size
new sizes (raw)To set the sizes as a new baseline, you can copy/paste next content to the {
"version": "6.4.4",
"timestamp": "2026-05-15",
"sizes": {
"templateApp": {
"css": 259446,
"js": 457328
},
"@epam/app": {
"css": 720897,
"js": 4938667
},
"@epam/electric": {
"css": 2275,
"js": 2883
},
"@epam/promo": {
"css": 47756,
"js": 9145
},
"@epam/uui-extra": {
"css": 0,
"js": 213
},
"@epam/loveship": {
"css": 55330,
"js": 43218
},
"@epam/uui-components": {
"css": 25157,
"js": 242379
},
"@epam/uui-core": {
"css": 0,
"js": 337461
},
"@epam/uui-db": {
"css": 0,
"js": 42718
},
"@epam/uui-docs": {
"css": 2152,
"js": 197255
},
"@epam/uui-editor": {
"css": 12954,
"js": 164486
},
"@epam/uui-timeline": {
"css": 2199,
"js": 75104
},
"@epam/uui": {
"css": 215800,
"js": 345831
}
}
}Generated by: generate-components-api Total amount of exported types/props without JSDoc comments
New missing commentsNOTE: It's either a new exported types/props without JSDoc, or it's an existing code from which you deleted the JSDoc comments. |
i-runets
reviewed
May 15, 2026
| const { style: rawStyle, ...restRawProps } = rawProps; | ||
| const rootStyle = this.props.zIndex !== undefined || rawStyle | ||
| ? { | ||
| ...(typeof rawStyle === 'object' && rawStyle ? (rawStyle as React.CSSProperties) : {}), |
Collaborator
There was a problem hiding this comment.
I think we can skip this check for rawStyles type and just do this:
const rootStyle = rawStyle || this.props.zIndex !== undefined
? {
...(rawStyle ?? {}),
...(this.props.zIndex !== undefined ? { zIndex: this.props.zIndex } : {}),
}
: undefined;
rawStyle is already typed as React.CSSProperties(inherits from IHasRawProps<React.HTMLAttributes<HTMLDivElement>>), and from what I can see, UUI rarely does this kind of check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
z-indexcould exceed the old fixed snackbar value (100500), so notifications appeared behind the modal.uuiLayout.getTopOverlayZIndex(), keeping the previous value as a minimum so existing apps do not regress.LayoutContextexposes a stable top-overlay index based on registered layers;ErrorHandlerrecoveryModalBlockeruses the same source instead of a hardcodedz-index.Issue link:
3095