refactor: reorder if clause#81
Open
asmfstatoil wants to merge 4 commits into
Open
Conversation
doc: type hinting
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refines the retry decorator by adding type hints and simplifying the retry logging logic.
Changes:
- Added
loggingandOptionalimports and typed theloggerparameter. - Refactored retry-warning logging to avoid duplicated
logger is not Nonechecks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
40
to
41
| time.sleep(_delay) | ||
| _delay *= backoff_factor |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
franktore
reviewed
Jul 3, 2026
franktore
left a comment
franktore
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but agree with copilot on avoiding unnecessary delay for _tries=0 case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc: type hinting
Description
Simplified code and reduced some function calls, and added type hinting.
Type of change
Refactor.
How Has This Been Tested?
Running test cases.
Checklist: