32211 Add state parent class to subscription patch request#86
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for patching IMS subscription “state” fields by introducing a dedicated parent TypedDict model and expanding the subscription patch request model accordingly. Also extends the existing API test suite with coverage for the IMS Subscriptions Management PATCH endpoint.
Changes:
- Introduced
SubscriptionStatePatchModeland madeSubscriptionPatchRequestIteminherit from it. - Corrected
plantSapCodetype inSubscriptionPatchRequestItemtoOptional[str]. - Added IMS Subscriptions Management API PATCH tests and minor assertion formatting cleanup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test_api.py |
Adds fixture and tests for IMSSubscriptionsManagementAPI.patch_subscription_by_uid; refactors a few assertions for readability. |
src/omnia_timeseries/models.py |
Adds state patch parent TypedDict and updates the subscription patch request model (including fixing plantSapCode type). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
janny93
reviewed
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added parent class with state parameters that the ims subscription management api allows for the patch endpoint. Intentionally left the datalastaccessed parameter out as this is intended to be used/maintained via function app.
Added some simple tests for the endpoint.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I Have run existing and new tests
Checklist: