Skip to content

README: correct six sentences from the 1.16.0 refresh #247

Closed

Description

@ericlitman

Introduced by: #246

Outcome

Six sentences that #246 wrote or left in README.md and docs/reference.md match the files they describe.

Defects

An independent read of #246 against main (bebfc0a8) found:

  1. README.md:177: "lists each adaptation and each upstream change it leaves out in UPSTREAM.md". UPSTREAM.md:15 says CHANGES.md and NOTICE.md describe the adaptations, and README.md:168 calls CHANGES.md the record of every adaptation.
  2. README.md:46: "For the full three-model review". README: refresh "What Open Pstack adds" and other stale text for 1.16.0 #245's revised acceptance asks that text about the default panel say it is the default.
  3. README.md:157: "pstack itself runs inside Claude Code or Codex". Lauren's pstack runs in Cursor (README.md:13). The sentence means Open Pstack.
  4. README.md:96: "After its smoke test, setup offers to generate a verification skill and a formal verification skill". On a rerun that changes nothing, setup mentions each offer in one line and does not ask (plugins/pstack/skills/setup-pstack/SKILL.md:126, :130; CHANGES.md 1.16.0).
  5. README.md:21 and the "Other models" row at README.md:154: "signed-in command-line tool(s)". OpenCode's free model needs no key (CHANGES.md, 1.12.0), and Grok accepts XAI_API_KEY (model-catalog.md:102).
  6. docs/reference.md:5: "Grok and six read-only providers run as lanes through the bundled runner". Codex lanes from Claude Code and Claude lanes from Codex also use the runner (model-catalog.md, Routes; docs/reference.md:210).

Acceptance criteria

  • Each of the six sentences matches the file it cites.
  • No other text changes.
  • The live gate records no runtime change.

Not in scope

docs/reference.md:89 lists only the Claude and Codex optional models. That list was not part of #245 and is recorded here only.

Activity

  1. ericlitman commented on Oct 22, 2026

    @ericlitman
    OwnerAuthor

    The fix is open as #248.

  2. added a commit that references this issue on Oct 22, 2026
  3. ericlitman commented on Oct 22, 2026

    @ericlitman
    OwnerAuthor

    Closeout, checked by an independent reader. Merged as #248.

    Six sentence corrections (#247)

    I filed #247 at 07:24:50Z with Introduced by: https://github.com/ericlitman/open-pstack/pull/246. Its criteria are from its creation text; it has no later version.

    1. "Each of the six sentences matches the file it cites."
      Done as written. Nine sentences changed on seven lines: the "signed-in" wording appeared in three sentences, and splitting the README.md:96 replacement added one. [Reader correction: the draft said eight replacements.]
      • [Reader correction] The design pass (gpt-6-astra, -c model_reasoning_effort=high) confirmed five defects and partly confirmed the README.md:177 defect: UPSTREAM.md:44-56 also records adaptations, and UPSTREAM.md:88 requires new ones there, so the old sentence was misleading, not false. It found the scope right.
      • [Reader addition] The design pass could not reach GitHub. It checked the README.md:46 defect against my quotation of README: refresh "What Open Pstack adds" and other stale text for 1.16.0 #245's criterion, which README: refresh "What Open Pstack adds" and other stale text for 1.16.0 #245's body does contain: "Text about the default panel says it is the default."
      • I took its replacements with these changes. [Reader correction: the draft named two.] I split its README.md:96 replacement into two sentences and dropped "applicable" and "without asking". I shortened its docs/reference.md:5 replacement. At README.md:177 I kept the original wording for the sync point and exclusions, and named only CHANGES.md for adaptations, because README.md:168 and :169 call CHANGES.md the change record and NOTICE.md the attribution record. At README.md:46 I kept the imperative "install and authenticate".
      • The build lane (pstack:pstack-opus-medium) reported, in its final message to this session, that it checked each replacement against its source and none contradicted. [Reader correction: the draft cited no record for this.] The PR body's Evidence table gives the source for each sentence, and the second reader confirmed all nine on main.
    2. "No other text changes."
      Done as written: 7 insertions and 7 deletions in README.md and docs/reference.md.
    3. "The live gate records no runtime change."
      Done as written. verify-open-pstack ran from main bebfc0a8, planned 0 sessions, and published live-gate success on d585f45f.

    #248 left draft at 07:29:25Z. verify passed at 07:30:10Z, and Mergify merged it at 07:30:56Z. Greptile's summary came at 07:32:27Z and Unfret's light review at 07:34:27Z, both after the merge.

    Not filed for work: docs/reference.md:89 lists only the Claude and Codex optional models. It is recorded on #247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions