Add LICENSE (BSD-3-Clause, retaining Go authors notice) - #10
Open
AskAlexSharov wants to merge 4 commits into
Open
Add LICENSE (BSD-3-Clause, retaining Go authors notice)#10AskAlexSharov wants to merge 4 commits into
AskAlexSharov wants to merge 4 commits into
Conversation
keccakf_arm64.s carries a Go-project copyright header pointing at "the LICENSE file", which did not exist — the rounds body is copied verbatim from Go's crypto/internal/fips140/sha3/sha3_arm64.s, and the package as a whole derives from golang.org/x/crypto/sha3, whose asm was removed upstream. BSD-3-Clause requires shipping the license text alongside the copied code, and the repo was otherwise unlicensed. License the whole repository under the same BSD-3-Clause text, keeping the Go authors' copyright line — the same approach go-ethereum took when it vendored the x/crypto keccak code.
There was a problem hiding this comment.
Pull request overview
Adds a repository-wide LICENSE file to address missing licensing/attribution for code derived from Go / x/crypto (notably the arm64 assembly referencing a LICENSE file).
Changes:
- Introduces a BSD-3-Clause LICENSE at repo root.
- Adds copyright lines and a brief provenance note for derived Go code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AskAlexSharov
force-pushed
the
chore/add-license
branch
from
July 20, 2026 08:16
113db04 to
30c32f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
keccakf_arm64.scarries a Go-project copyright header saying "license that can be found in the LICENSE file" — but the repo had no LICENSE file. The rounds body is copied verbatim from Go'scrypto/internal/fips140/sha3/sha3_arm64.s(diffed to confirm), and the package as a whole derives fromgolang.org/x/crypto/sha3after upstream dropped its asm. BSD-3-Clause requires retaining the copyright notice and license text.What
Single BSD-3-Clause LICENSE covering the whole repository, with both copyright lines (erigon authors + Go authors) and a short provenance note. This is the same approach go-ethereum took when it vendored the x/crypto keccak code after upstream removed the assembly.
If maintainers prefer a different license for the original portions (Apache-2.0 like other erigontech libs), the Go BSD-3 notice still must remain for the derived files — happy to restructure.