Skip to content

chore: update TypeScript to v6#740

Open
sethamus wants to merge 12 commits into
eslint:mainfrom
sethamus:update-typescript-to-v6
Open

chore: update TypeScript to v6#740
sethamus wants to merge 12 commits into
eslint:mainfrom
sethamus:update-typescript-to-v6

Conversation

@sethamus
Copy link
Copy Markdown

@sethamus sethamus commented Mar 26, 2026

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

This PR updates the repo’s TypeScript tooling to v6.

What changes did you make? (Give an overview)

  • bump typescript to v6 in package.json.
  • updated the TypeScript module settings to use moduleResolution: "nodenext" and module: "nodenext" instead of the deprecated moduleResolution: "node" setup.
  • added rootDir: "lib" to eslint-visitor-keys.

Related Issues

Is there anything you'd like reviewers to focus on?

@nzakas
Copy link
Copy Markdown
Member

nzakas commented Mar 26, 2026

Please hold off. There's already a bunch of "Update TypeScript to v6" PRs across the org and we're not even sure we want to upgrade immediately.

@sethamus
Copy link
Copy Markdown
Author

sethamus commented Mar 27, 2026

@nzakas Sorry for the PRs! I opened these based on the discussion in my other PR (eslint/eslint#20547 (comment)), which suggested that once TypeScript 6 is officially released, we should update our tooling.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added Stale and removed Stale labels Apr 6, 2026
@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Apr 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions Bot added the Stale label Apr 20, 2026
@sethamus sethamus marked this pull request as ready for review April 22, 2026 15:23
@github-actions github-actions Bot removed the Stale label Apr 22, 2026
@nzakas
Copy link
Copy Markdown
Member

nzakas commented Apr 24, 2026

Gotcha. @fasttime I'll leave it up to you to review.

Copy link
Copy Markdown
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that there are currently some CI failures related to this update.

Comment thread package.json
@fasttime
Copy link
Copy Markdown
Member

The type tests are still failing.

Comment thread tsconfig.base.json
Comment thread packages/eslint-scope/tests/types/tsconfig.json
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the named export test was removed?

This test verifies that the named export types exist correctly in the CJS export, so I think it need to be retained.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would otherwise get:

ECMAScript imports and exports cannot be written in a CommonJS file under 'verbatimModuleSyntax'.

Comment thread packages/eslint-visitor-keys/test-d/index.test-d.ts Outdated
@fasttime
Copy link
Copy Markdown
Member

Are the types wrong? CI job is now failing with attw --pack crashing on Cannot read properties of undefined (reading 'filename'). This seems related to arethetypeswrong/arethetypeswrong.github.io#258, and may require the same temporary workaround used in eslint/eslint#20877 or eslint/rewrite#458.

@fasttime
Copy link
Copy Markdown
Member

To clear the CI failure: #751.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Implementing

Development

Successfully merging this pull request may close these issues.

4 participants