Native: Subfolder for File Explorer & Selection in Recent Sessions & Cleanup + Fixes#2550
Merged
Merged
Conversation
* DLT statistics shouldn't run when storage header isn't available making PCAP files not suitable source for them. * This change is ported from logic in Chipmunk 3
* Add check before opening new recent session to ensure session is still valid while application is running then show a modal prompt to remove item for recent sessions. * This can happen if file is removed while chipmunk is running as sanitizing happen on startup only.
* Keyboard control to select items in recent session listing to enable starting a recent session with keyboard only * We avoided creating caches as the number of recent sessions isn't expected to be more than 100
Wait until the output file is written before applying search filters in recent session to avoid race conditions when search is applied before output file is written
Avoid adding UI signals inside recent session restore as it's not running in UI rendering scope. Change make the function arguments simpler without avoiding UI related arguments passing
* File explorer supports sub folders with scanning with depth of 5. * Service will scan files and folders and send the data to the UI * Search will run on all favorite and their sub-folders * Search will be cached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes multiple changes and fixes: