fix(bindgen): generate constructors for abstract bridge classes#304
Open
wrbl606 wants to merge 1 commit into
Open
fix(bindgen): generate constructors for abstract bridge classes#304wrbl606 wants to merge 1 commit into
wrbl606 wants to merge 1 commit into
Conversation
The $constructors filter in bindgen was excluding non-factory constructors for abstract classes, but bridge classes themselves are concrete -- even when the class they wrap is abstract. This caused a runtime UnimplementedError when instantiating subclasses of an abstract bridge class in the eval VM. Added `|| isBridge` to the filter so bridge class constructors are always generated regardless of the source class's abstractness. Also added 3 test cases covering subclassing abstract bridges with positional params, named/required params, and returning instances to the host. Closes #275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The $constructors filter in bindgen was excluding non-factory constructors for abstract classes, but bridge classes themselves are concrete - even when the class they wrap
is abstract. This caused an UnimplementedError when instantiat
ing subclasses of an abstract bridge class in the VM.
Added
|| isBridgeto the filter so bridge class constructors are always generated regardless of the sourceclass's abstractness.
Closes #275