WIP: First pass at adding to glossary and readme#23
Conversation
|
Oh, and apologies for the extra whitespace and changing *italic* to _italic_, I have formatOnSave activated and had the changes committed before I realised |
|
Thanks @OisinKyne for opening this issue. We require a term to describe an participating entity existing only inside the Distributed Validator Protocol, and which is identified by a unique BLS key and has assigned responsibilities in the protocol. The term This is similar in spirit to the Ethereum spec, where the I agree that we need another term for the entity running a |
|
Okay cool, that works for me :) One more question/point of clarification.
To make sure I have this right, a co-validator could consist both of the BLS key that is part of the threshold signing scheme and a separate SECP256K1 key used for the p2p discovery/peering layer of the DVC, yes? |
3c337e2 to
4cf9148
Compare
I have a question about the term co-validator @adiasg, here are some excerpts that I don't think are consistent.
from glossary.md
from ./dvspec/spec.py
In the first example, a co-validator is a single BLS key, in the next two a co-validator is what we have been calling an operator. In the python file, the
CoValidatorclass is closer to the BLS key concept.Might I suggest that co-validator is ambiguous, and that maybe the terms
OperatorandDistributed Validator Key Shareare more clear? Or we could keep co-validator to mean key share but I would sayco-validator keynot justco-validatoras is, because most people I have talked to infer co-validator to mean operator/person, not private key. Obviously this is a reflection of the eth2 spec itself considering people don't differentiate between person who runs a validator, a validator client, and a validator key, all of them get ambiguously called validator too.Would like to get your thoughts on this before this PR is ready to merge, as I have only touched the markdown files, and haven't made any changes to the .py files until I've gotten your perspective, and would like to reflect what we pick in both places rather than adding even more inconsistency.