Skip to content

docs(spec-specs): fix TransactionEnvironment docstring#2936

Merged
SamWilsn merged 1 commit into
ethereum:forks/amsterdamfrom
nanookclaw:fix/transaction-environment-docstring
Jun 2, 2026
Merged

docs(spec-specs): fix TransactionEnvironment docstring#2936
SamWilsn merged 1 commit into
ethereum:forks/amsterdamfrom
nanookclaw:fix/transaction-environment-docstring

Conversation

@nanookclaw
Copy link
Copy Markdown
Contributor

Summary

Fixes the TransactionEnvironment docstring in the Berlin VM module so it describes transaction-level processing instead of repeating the Message wording about contract creation or message calls.

The issue points to this as a copy-paste error from Message; this PR keeps the change scoped to that documented Berlin fork location and leaves behavior untouched.

Closes #2929

Verification

  • uv run ruff format --check src/ethereum/forks/berlin/vm/__init__.py
  • uv run ruff check src/ethereum/forks/berlin/vm/__init__.py
  • git diff --check

@SamWilsn SamWilsn force-pushed the fix/transaction-environment-docstring branch 2 times, most recently from 02ab39f to 2aa2254 Compare June 1, 2026 15:58
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (cb77cc5) to head (8cef715).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2936   +/-   ##
================================================
  Coverage            90.50%   90.50%           
================================================
  Files                  535      535           
  Lines                32407    32407           
  Branches              3011     3011           
================================================
  Hits                 29331    29331           
  Misses                2559     2559           
  Partials               517      517           
Flag Coverage Δ
unittests 90.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danceratopz danceratopz added A-doc Area: documentation A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) labels Jun 2, 2026
@danceratopz danceratopz changed the title docs: fix TransactionEnvironment docstring docs(spec-specs): fix TransactionEnvironment docstring Jun 2, 2026
@SamWilsn SamWilsn force-pushed the fix/transaction-environment-docstring branch from acb034a to 8cef715 Compare June 2, 2026 13:43
@SamWilsn SamWilsn merged commit 14eca5d into ethereum:forks/amsterdam Jun 2, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-doc Area: documentation A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix docstring for TransactionEnvironment

3 participants