all: update constructor codes for geas v0.3.0#42
Merged
Conversation
This fixes warnings issued by geas v0.3.0 and also improves the constructor code a bit by adding stack comments.
Collaborator
Author
|
I added another change. LMK if you hate it. |
Collaborator
Author
|
Mostly did this so I can put a stack comment on the correct column even on the first line. Also might be marginally better since there is no need to question the number of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes warnings issued by geas v0.3.0 and also improves the constructor code a bit by adding stack comments. I have manually verified the bytecode is identical with this update. At some point we should probably hard-code the hashes somewhere to lock in the code as deployed on-chain.