fix: adapt certbot flags to modern certbot (2.3.1)#35
Merged
Conversation
The container builds FROM certbot/certbot:latest, so a newer certbot broke two commands on ethicserver: - `easy proxy certbot-ionos` aborted with "ambiguous option: --dns-ionos". The bare --dns-ionos selector only exists for certbot's official plugins; with the third-party dns-ionos plugin it is an ambiguous prefix of --dns-ionos-credentials / --dns-ionos-propagation-seconds. Select the plugin with `--authenticator dns-ionos` instead. - `easy proxy certbot` aborted with "unrecognized arguments: --manual-public-ip-logging-ok". That flag was removed from modern certbot (IP-logging consent is no longer prompted). Dropped it. Tests: new mock_docker_running_record helper records `docker exec` args; two bats tests assert the corrected flags. Full suite 54/54. Knowledge base: recorded the certbot:latest flag-drift gotcha. Note: `easy proxy rfc2136` failing on ethicserver is server-side config, not a code bug — /etc/letsencrypt/secret.txt has a hostname for dns_rfc2136_server (certbot requires an IP) and loose file permissions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
montoyaedu
added a commit
that referenced
this pull request
Jun 9, 2026
- SERVER_RUNBOOK.md: recovery runbook for ethicserver after the certbot failures — update CLI, recreate the container (broken bind mount + load the valid cert), switch to an auto-renewing IONOS wildcard, plus troubleshooting and cert-verification commands. - STATE.md: was stale at v2.0.0; now reflects v2.3.2, the 2026-06-09 certbot fixes (#35/#36), current WIP/blockers, and next steps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
ethicserverthe SSL commands fail because the container buildsFROM certbot/certbot:latestand a newer certbot changed its CLI:easy proxy certbot-ionos ethiclab.it→certbot: error: ambiguous option: --dns-ionos could match --dns-ionos-propagation-seconds, --dns-ionos-credentialseasy proxy certbot→certbot: error: unrecognized arguments: --manual-public-ip-logging-okFix (
commands/proxy.sh)--authenticator dns-ionosinstead of the bare--dns-ionos. The bare--dns-<name>selector only exists for certbot's official plugins; the third-partydns-ionosplugin only registers--dns-ionos-credentials/--dns-ionos-propagation-seconds, so--dns-ionosis now an ambiguous prefix.--authenticator dns-ionosis unambiguous and version-proof.--manual-public-ip-logging-ok, removed from modern certbot (IP-logging consent is no longer prompted).Tests
mock_docker_running_recordhelper recordsdocker execargs.npm run lintnot run — shellcheck not installed on this machine; CI runs it pinned to v0.11.0. Changes are flag-only, no new shell constructs.)Release
Patch bump 2.3.0 → 2.3.1:
package.json,CLAUDE.md,CHANGELOG.md, version assertions intest/dispatcher.bats. Merging gives a directly-installable version.Out of scope — server-side, not a repo bug
easy proxy rfc2136failed onethicserverdue to config in/etc/letsencrypt/secret.txt:dns_rfc2136_serveris set to a hostname (enneesseuno.ethiclab.it); certbot requires an IP.chmod 600 /etc/letsencrypt/secret.txt.Follow-up
Consider pinning the certbot base image to a fixed tag instead of
:latestto stop silent CLI drift on rebuild (recorded in the knowledge base).🤖 Generated with Claude Code