Skip to content

Refactor client cert methods with RAII and fix security issues

436bc41
Select commit
Loading
Failed to load commit list.
Merged

Add client certificate authentication and SNI callback support #364

Refactor client cert methods with RAII and fix security issues
436bc41
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 5, 2026 in 0s

68.62% (-1.92%) compared to 42e769c

View this Pull Request on Codecov

68.62% (-1.92%) compared to 42e769c

Details

Codecov Report

❌ Patch coverage is 41.22807% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.62%. Comparing base (42e769c) to head (436bc41).

Files with missing lines Patch % Lines
src/http_request.cpp 40.36% 18 Missing and 47 partials ⚠️
src/webserver.cpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   70.54%   68.62%   -1.92%     
==========================================
  Files          28       28              
  Lines        1436     1549     +113     
  Branches      570      629      +59     
==========================================
+ Hits         1013     1063      +50     
- Misses         35       50      +15     
- Partials      388      436      +48     
Files with missing lines Coverage Δ
src/httpserver/create_webserver.hpp 96.98% <100.00%> (+0.04%) ⬆️
src/httpserver/http_request.hpp 84.21% <ø> (ø)
src/webserver.cpp 58.68% <0.00%> (-0.13%) ⬇️
src/http_request.cpp 60.06% <40.36%> (-10.33%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e769c...436bc41. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.