Enhance Draft Test Functionality in Agent Module#1
Closed
haasonsaas wants to merge 1 commit into
Closed
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit dad2993. Bugbot is set up for automated code reviews on this repo. Configure here. |
haasonsaas
added a commit
that referenced
this pull request
Jun 21, 2026
…a to model
Two wiring bugs that prevented the runtime from working against a real
provider, found by running summarize.act against OpenRouter:
1. The `using <alias>` handle (e.g. "coder") was sent to the API as the
model name, 400-ing against any real provider. The alias is a
source-level handle; the concrete model always comes from OPENAI_MODEL.
The comment said this was the intent — the condition was inverted.
2. The infer prompt never told the model what shape to return, so it
guessed field names (returned {"summary": ...} for a type named Summary
with a `text` field). Coercion then silently dropped the field.
InferRequest now carries a compact type schema (rendered from the AST +
TypeRegistry) and the prompt includes it: "Respond with only valid JSON
matching this shape: { text: String }".
Verified end-to-end against real services:
OPENAI_API_KEY=... OPENAI_BASE_URL=https://openrouter.ai/api/v1 \
OPENAI_MODEL=openai/gpt-4o-mini GITHUB_TOKEN=... \
actc run examples/summarize.act summarize \
repo='{"owner":"evalops","name":"act"}' path='"README.md"'
=> {"ok":{"text":"Act is a pre-alpha programming language..."}}
actc run examples/open_pr.act open_pr ... => {"ok":"#1"}
(PR opened, then closed + branch deleted — full write path proven.)
clippy 0, fmt clean, 53 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the draft test capabilities in the agent module, ensuring more accurate and efficient processing of drafts.