Skip to content

EEBus: upgrade and add tests#28908

Draft
andig wants to merge 3 commits intomasterfrom
chore/eebus
Draft

EEBus: upgrade and add tests#28908
andig wants to merge 3 commits intomasterfrom
chore/eebus

Conversation

@andig
Copy link
Copy Markdown
Member

@andig andig commented Apr 7, 2026

Adds a controlbox unit test. Depends on enbility release.

@andig andig added infrastructure Basic functionality backlog Things to do later labels Apr 7, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The replace github.com/enbility/eebus-go => ../eebus-go entry in go.mod hardcodes a local path and will break consumers/CI that don’t have that directory layout; consider removing it or gating it behind a local-only config.
  • The enbility dependencies are now pinned to pseudo-versions with future timestamps; double-check that these are intentional release candidates rather than local or temporary builds before merging.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `replace github.com/enbility/eebus-go => ../eebus-go` entry in go.mod hardcodes a local path and will break consumers/CI that don’t have that directory layout; consider removing it or gating it behind a local-only config.
- The enbility dependencies are now pinned to pseudo-versions with future timestamps; double-check that these are intentional release candidates rather than local or temporary builds before merging.

## Individual Comments

### Comment 1
<location path="go.mod" line_range="270" />
<code_context>

 replace go.yaml.in/yaml/v4 => go.yaml.in/yaml/v4 v4.0.0-rc.3
+
+replace github.com/enbility/eebus-go => ../eebus-go
</code_context>
<issue_to_address>
**issue (bug_risk):** Local replace directive will break consumers who don’t have ../eebus-go.

This hardcodes your local directory structure into go.mod and will fail for others or in CI where `../eebus-go` isn’t present. If it’s only needed for local development, keep it out of the committed go.mod (e.g., via a local GOWORK/GOFLAGS setup or another local-only config).
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread go.mod

replace go.yaml.in/yaml/v4 => go.yaml.in/yaml/v4 v4.0.0-rc.3

replace github.com/enbility/eebus-go => ../eebus-go
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Local replace directive will break consumers who don’t have ../eebus-go.

This hardcodes your local directory structure into go.mod and will fail for others or in CI where ../eebus-go isn’t present. If it’s only needed for local development, keep it out of the committed go.mod (e.g., via a local GOWORK/GOFLAGS setup or another local-only config).

@andig andig marked this pull request as draft April 15, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backlog Things to do later infrastructure Basic functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant